gh-129185: Fix crash during interpreter finalization in PyTraceMalloc_Untrack #129188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I wrote a different fix with a test: PR gh-129191. |
|
Thanks @vstinner! Closing this one |
vstinner
reviewed
Jan 22, 2025
| /* Finalize any remaining import state */ | ||
| // XXX Move these up to where finalize_modules() is currently. | ||
| _PyImport_FiniCore(tstate->interp); | ||
| _PyImport_Fini(); | ||
|
|
||
| /* Disable tracemalloc after all Python objects have been destroyed, | ||
| so it is possible to use tracemalloc in objects destructor. */ | ||
| _PyTraceMalloc_Fini(); |
There was a problem hiding this comment.
I don't think that this fix is enough. Some objects can be deleted later, in finalize_interp_clear(). So I wrote a different fix to restore the old behavior: PR gh-129191.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash by moving
_PyTraceMalloc_Fini()after_PyImport_Fini(). I'm not sure if it breaks some invariant that I'm not aware of or even if it's the best solution, happy to take feedbacks!