Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-129158: Fix unwanted trailing whitespace in test_asyncio.test_subprocess #129181

Merged
merged 1 commit into from
Jan 22, 2025
Merged

gh-129158: Fix unwanted trailing whitespace in test_asyncio.test_subprocess #129181

merged 1 commit into from
Jan 22, 2025

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jan 22, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2025
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jan 22, 2025
@AlexWaygood
Copy link
Member

Oh, looks like @picnixz got there a few seconds before you in #129180

@picnixz
Copy link
Member

picnixz commented Jan 22, 2025

So... who merges what? I like your title though so I think yours is better :')

@picnixz picnixz mentioned this pull request Jan 22, 2025
Closed
vstinner
vstinner approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) January 22, 2025 13:40
@vstinner vstinner merged commit 2ed5ee9 into python:main Jan 22, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@picnixz picnixz picnixz approved these changes

@graingert graingert graingert approved these changes

@vstinner vstinner vstinner approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ambv @AlexWaygood @picnixz @vstinner @graingert