gh-129158: Ensure we restore unix_events.can_use_pidfd after SubprocessThreadedWatcherTests finishes #129160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bprocessThreadedWatcherTests finishes
pablogsal
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
| # Force the use of the threaded child watcher | ||
| unix_events.can_use_pidfd = mock.Mock(return_value=False) | ||
| super().setUp() | ||
|
|
There was a problem hiding this comment.
@pablogsal Why did you merge this without this line fix? I had suggested it to fix the lint CI and now it is broken on main too. https://github.com/python/cpython/actions/runs/12908528443/job/35994236140
There was a problem hiding this comment.
I merged this from my phone and I didn't see the comment. Apologies!
There was a problem hiding this comment.
Don't worry I will make a PR fixing this in the next hour
There was a problem hiding this comment.
I've made #129180 (sorry didn't see your comment before...)
kumaraditya303
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.