Skip to content

gh-128595: Fix test__colorize unexpected keyword argument 'file' on buildbots #129070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

gh-128595: Fix test__colorize unexpected keyword argument 'file' on buildbots #129070

merged 2 commits into from
Jan 21, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 20, 2025 •
edited
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jan 20, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Closed
@hugovk

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@hugovk

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 20, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 9ddc74f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 20, 2025
@hugovk hugovk mentioned this pull request Jan 20, 2025
Merged
@hugovk hugovk marked this pull request as ready for review January 20, 2025 16:08
@hugovk hugovk mentioned this pull request Jan 20, 2025
Merged
vstinner
vstinner reviewed Jan 20, 2025
View reviewed changes
@hugovk hugovk merged commit 417f7a9 into python:main Jan 21, 2025
41 checks passed
@hugovk hugovk deleted the 3.14-fix-colorize-buildbot branch January 21, 2025 09:20
hugovk added a commit to hugovk/cpython that referenced this pull request Jan 21, 2025
@hugovk
pythongh-128595: Fix test__colorize unexpected keyword argument 'fi…
0bd114e 
…le' on buildbots (python#129070)
hugovk added a commit that referenced this pull request Jan 21, 2025
@hugovk @serhiy-storchaka @vstinner
[3.13] gh-128595: Default to stdout isatty for colour detection inste…
383af39 
…ad of stderr (GH-128498) (#129057)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Fix `test__colorize` unexpected keyword argument 'file' on buildbots (#129070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @bedevere-bot @vstinner @serhiy-storchaka