Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36690: Fix typing error in demo rpython.py #12903

Merged
merged 1 commit into from
Apr 22, 2019
Merged

bpo-36690: Fix typing error in demo rpython.py #12903

merged 1 commit into from
Apr 22, 2019

Conversation

BriFuture
Copy link
Contributor

@BriFuture BriFuture commented Apr 22, 2019 •
edited by bedevere-bot
Loading

Fixed typing error in File Tools/demo/rpython.py at Line 22 where port[i+1:] should be host[i+1:]

https://bugs.python.org/issue36690

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

tirkarthi
tirkarthi approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@berkerpeksag berkerpeksag changed the title bpo36690: Fix typing error in demo rpython.py bpo-36690: Fix typing error in demo rpython.py Apr 22, 2019
berkerpeksag
berkerpeksag approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't wait for the CLA since this is a pretty trivial patch. However, please sign the CLA form if you're planning to continue contributing to Python.

Thank you!

@berkerpeksag berkerpeksag merged commit d59b662 into python:master Apr 22, 2019
@miss-islington
Copy link
Contributor

Thanks @BriFuture for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-12906 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
@BriFuture @miss-islington
bpo-36690: Fix typo in Tools/demo/rpython.py (pythonGH-12903)
29c6280 
(cherry picked from commit d59b662)

Co-authored-by: 周家未 <752736341@qq.com>
berkerpeksag pushed a commit that referenced this pull request Apr 22, 2019
@miss-islington @BriFuture @berkerpeksag
bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903)
5407aaf 
(cherry picked from commit d59b662)

Co-authored-by: 周家未 <752736341@qq.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD CURRENT Shared 3.7 has failed when building commit 5407aaf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/173/builds/421) and take a look at the build logs.
  4. Check if the failure is related to this commit (5407aaf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/173/builds/421

Click to see traceback logs 
From https://github.com/python/cpython
 * branch                  3.7        -> FETCH_HEAD
Reset branch '3.7'

Timeout (0:25:00)!
Thread 0x000000080135b000 (most recent call first):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/selectors.py", line 415 in select
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 1681 in _communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 939 in communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 56 in run_test_in_subprocess
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 120 in _runtest
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 145 in run
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 917 in _bootstrap_inner
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 885 in _bootstrap

Thread 0x00000008017c4600 (most recent call first):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/selectors.py", line 415 in select
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 1681 in _communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 939 in communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 56 in run_test_in_subprocess
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 120 in _runtest
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 145 in run
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 917 in _bootstrap_inner
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 885 in _bootstrap

Thread 0x00000008017c4b00 (most recent call first):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/selectors.py", line 415 in select
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 1681 in _communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 939 in communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 56 in run_test_in_subprocess
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 120 in _runtest
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 145 in run
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 917 in _bootstrap_inner
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 885 in _bootstrap

Thread 0x00000008017c4100 (most recent call first):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 1701 in _communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/subprocess.py", line 939 in communicate
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 56 in run_test_in_subprocess
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 120 in _runtest
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 145 in run
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 917 in _bootstrap_inner
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 885 in _bootstrap

Thread 0x0000000800a9a000 (most recent call first):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/threading.py", line 300 in wait
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/queue.py", line 179 in get
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/runtest_mp.py", line 185 in run_tests_multiprocess
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/main.py", line 513 in run_tests
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/main.py", line 619 in _main
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/main.py", line 586 in main
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/libregrtest/main.py", line 640 in main
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/__main__.py", line 2 in <module>
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/runpy.py", line 85 in _run_code
  File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/runpy.py", line 193 in _run_module_as_main

@BriFuture
Copy link
Contributor Author

@berkerpeksag Hi, I've signed CLA and confirmed my email address, but it seems my github accout cant pass the check on
https://check-python-cla.herokuapp.com.
What's the problem and how to do?

@berkerpeksag
Copy link
Member

A PSF staff needs to process your signed form and it usually takes a few US business days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BriFuture @the-knights-who-say-ni @miss-islington @bedevere-bot @berkerpeksag @tirkarthi