-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126703: Add freelists for list and tuple iterators #128592
Conversation
Benchmarks show a 0.7% speedup, with no obvious pattern. This could be noise or a real speedup. Stats coming up... |
If I interpret correctly, we have 16% less allocations and 10% more objects from the freelist. The performance increase of 0.7% is roughly in line with the 0.2% increase from (#128692) if I look at the number of allocations avoided (see #126703 (comment), about 348M allocations for this PR, 165 PR for the other PR). (within noise of the benchmarks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
See the corresponding issue for allocation statistics and see #128368 for more discussion.