Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30158: Fix deprecation warnings in test_importlib introduced by … #1285

Merged
merged 1 commit into from
Apr 29, 2017
Merged

bpo-30158: Fix deprecation warnings in test_importlib introduced by … #1285

merged 1 commit into from
Apr 29, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 25, 2017 •
edited
Loading

…bpo-29576.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Apr 25, 2017
@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ericsnowcurrently and @Carreau to be potential reviewers.

@serhiy-storchaka serhiy-storchaka changed the title bpo-30158: Fix deprecation warnings in test_importlib introduced by b… bpo-30158: Fix deprecation warnings in test_importlib introduced by … Apr 25, 2017
@vstinner vstinner requested a review from brettcannon April 25, 2017 22:58
@vstinner
Copy link
Member

While ignoring the warning on find_module() and find_loader() tests make sense, I'm not sure about tests using find_module/find_loader. Should these tests be updated to use find_spec()?

@serhiy-storchaka
Copy link
Member Author

I don't know.

@brettcannon
Copy link
Member

It looks like the whole module is a bit lacking on the find_spec() tests and could stand an upgrade. I opened https://bugs.python.org/issue30202 to track that.

@serhiy-storchaka serhiy-storchaka merged commit 3cc8259 into python:master Apr 29, 2017
@serhiy-storchaka serhiy-storchaka deleted the test_importlib-warnings branch April 29, 2017 04:06
@vstinner
Copy link
Member

"I opened https://bugs.python.org/issue30202 to track that."

Thanks Brett for that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mention-bot @vstinner @brettcannon @the-knights-who-say-ni