Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36404: update PendingDeprecationWarning explanation #12837

Merged
merged 1 commit into from
Apr 15, 2019
Merged

bpo-36404: update PendingDeprecationWarning explanation #12837

merged 1 commit into from
Apr 15, 2019

Conversation

methane
Copy link
Member

@methane methane commented Apr 15, 2019 •
edited by bedevere-bot
Loading

@methane methane added docs Documentation in the Doc dir skip news needs backport to 3.7 labels Apr 15, 2019
@methane methane requested a review from ncoghlan April 15, 2019 11:53
@ncoghlan ncoghlan merged commit a3283ef into python:master Apr 15, 2019
@miss-islington
Copy link
Contributor

Thanks @methane for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2019
@methane @miss-islington
Doc: update PendingDeprecationWarning explanation (pythonGH-12837)
0ba3286 
Keep the nudge towards DeprecationWarning, but remove the
"Note" markup and generally shorten the description.

Ref: https://github.com/python/cpython/pull/12505/filesGH-r273978757
(cherry picked from commit a3283ef)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot
Copy link

GH-12838 is a backport of this pull request to the 3.7 branch.

@ncoghlan
Copy link
Contributor

Thanks @methane!

miss-islington added a commit that referenced this pull request Apr 15, 2019
@miss-islington @methane
Doc: update PendingDeprecationWarning explanation (GH-12837)
871ba6c 
Keep the nudge towards DeprecationWarning, but remove the
"Note" markup and generally shorten the description.

Ref: https://github.com/python/cpython/pull/12505/filesGH-r273978757
(cherry picked from commit a3283ef)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@methane methane deleted the pendingdeprecatedwarning branch May 29, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @miss-islington @bedevere-bot @ncoghlan @the-knights-who-say-ni