Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-76023: WinFSP giving WinError 1005 fix (Python 3.14.0a3) #128328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BecoKo
Copy link

@BecoKo BecoKo commented Dec 29, 2024

Make os.path.realpath to ignore WinError 1005 in non-strict mode. (Tested on Python 3.14.0a3 on Windows 11)

Cryptomator issue
python related issue

In cryptomator running WinFSP volume as administrator and make encrypted volumes available to all users, is not recommended.

This is retry of PR#128316 to Python 3.11 . (It seems that this is not a security issue.)

…contain a recognized file system

Make os.path.realpath to ignore WinError 1005 in non-strict mode. Issue: cryptomator/cryptomator#2359
@bedevere-app
Copy link

bedevere-app bot commented Dec 29, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz
Copy link
Contributor

picnixz commented Dec 29, 2024

(It seems that this is not a security issue.)

FTR, we usually make PRs against main and then we decide where we will backport them. We don't make PRs (except backports) against a past branch in general (because if there is an issue in an older branch, this issue usually remains...).

@ZeroIntensity ZeroIntensity requested a review from zooba December 30, 2024 18:04
@ZeroIntensity ZeroIntensity added OS-windows needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 30, 2024
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

@zooba
Copy link
Member

zooba commented Jan 1, 2025

Can we add a test?

Not trivially - we'd have to (automatically) set up a file system that exhibits this characteristic. But the overall mechanism (non-strict resolution) should be tested well enough.

With the NEWS entry (I suggest Make :meth:`os.path.realpath` ignore Windows error 1005 when in non-strict mode), this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants