Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks #128322

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Dec 29, 2024

Closes #128321

See the issue for context.

There are a few alternative approaches we could take, such as:

  • Always including -lm during checks (which would over-link)
  • Using PKG_CHECK_MODULES_STATIC instead of PKG_CHECK_MODULES when shared libraries are disabled

I'm not really sure of the trade-offs. This seems like the simplest approach to unblock users who can set PKG_CONFIG to include the --static flag as mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=19541#c7

configure.ac Outdated Show resolved Hide resolved
@zanieb zanieb changed the title gh-128321: Set LIBS during sqlite3 library build checks gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks Dec 30, 2024
@zanieb zanieb marked this pull request as ready for review December 30, 2024 05:24
@zanieb zanieb requested a review from corona10 as a code owner December 30, 2024 05:24
@erlend-aasland erlend-aasland merged commit 81376fe into python:main Dec 30, 2024
47 checks passed
@zanieb
Copy link
Contributor Author

zanieb commented Dec 30, 2024

Thanks for the review!

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
…quirements (pythonGH-128322)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
…quirements (pythonGH-128322)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 30, 2024

GH-128355 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 30, 2024

GH-128356 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 30, 2024
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
…equirements (GH-128322) (#128355)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
…equirements (GH-128322) (#128356)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statically linked sqlite3 fails checks due to missing -lm
2 participants