GH-127705: Add debug mode for _PyStackRefs inspired by HPy debug mode
#128121
+395
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
requested review from
Fidget-Spinner,
ericsnowcurrently and
erlend-aasland
as code owners
Misc/NEWS.d/next/Core_and_Builtins/2024-12-20-12-25-16.gh-issue-127705.WmCz1z.rst
Show resolved
Hide resolved
Fidget-Spinner
approved these changes
Dec 20, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
_PyStackRefsifPy_STACKREF_DEBUGis set.When reporting leaks, both the origin of the
_PyStackRefand the last call toPyStackRef_AsPyObjectBorroware reported.Only supports the default build for now. It shouldn't be too hard to support free-threading in the future.
Running on the full test suite passes all but these tests:
Expecting a
_PyStackRefto look like a tagged pointer, not an index. Mostly segfaultstest.test_gdb.test_backtrace
test.test_gdb.test_misc
test.test_gdb.test_pretty_print
test_external_inspection
Calling a
_PyStackRef...function without holding the GIL at shutdown.test_faulthandler
test_regrtest
Actual leaks
test.test_multiprocessing_spawn.test_manager
test_repl
test_threading