bpo-36593: Fix isinstance check for Mock objects with spec executed under tracing #12790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
changed the title
pablogsal
reviewed
Apr 13, 2019
|
Thanks @pablogsal for the review :) I think this shouldn't have failed and have created an issue for |
|
Thanks @tirkarthi for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2019
…nder tracing (pythonGH-12790) In Python having a trace function in effect while mock is imported causes isinstance to be wrong for MagicMocks. This is due to the usage of super() in some class methods, as this sets the __class__ attribute. To avoid this, as a workaround, alias the usage of super . (cherry picked from commit 830b43d) Co-authored-by: Xtreak <tir.karthi@gmail.com>
|
GH-12821 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 13, 2019
…nder tracing (GH-12790) In Python having a trace function in effect while mock is imported causes isinstance to be wrong for MagicMocks. This is due to the usage of super() in some class methods, as this sets the __class__ attribute. To avoid this, as a workaround, alias the usage of super . (cherry picked from commit 830b43d) Co-authored-by: Xtreak <tir.karthi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs only when the mock module import and code are executed under tracing. In order to test this I have tried patching
sys.modulesto removeunittest.mockin order to trigger an import under tracing. Thoughunittest.mockis deleted reference tounittest.mock.patchis held by two tests (test_patch_dict_test_prefix and test_patch_test_prefix) that change theTEST_PREFIX. Hence somehow there is a difference in theunittest.mock.patchobject referred under these tests and inside mock module causing reference to unchangedTEST_PREFIXand hence test case failures. So I have kept a reference to old patch object and restored it in the end of this test to make sure everything is in sync.https://bugs.python.org/issue36593