Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

Merged
merged 4 commits into from
Nov 19, 2024
Merged

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

merged 4 commits into from
Nov 19, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 12, 2024 •
edited by bedevere-app bot
Loading

@vstinner
pythongh-126594: Fix typeobject.c wrap_buffer() cast
019df14 
Reject flags smaller than INT_MIN.
@vstinner vstinner added skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Closed
@JelleZijlstra JelleZijlstra self-requested a review November 13, 2024 00:10
@vstinner
Copy link
Member Author

@JelleZijlstra: Do you want to review this change?

JelleZijlstra
JelleZijlstra reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding a test? I understand this condition can perhaps only be triggered on some platforms.

Objects/typeobject.c Outdated Show resolved Hide resolved
vstinner and others added 3 commits November 16, 2024 00:03
@vstinner @JelleZijlstra
Update Objects/typeobject.c
9a6bcc7 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@vstinner
Merge branch 'main' into wrap_buffer
b70e0de
@vstinner
Add test
0351e7f
@vstinner
Copy link
Member Author

Do you think it's worth adding a test? I understand this condition can perhaps only be triggered on some platforms.

Sure, I added a test.

@vstinner vstinner merged commit 84f07c3 into python:main Nov 19, 2024
41 checks passed
@vstinner vstinner deleted the wrap_buffer branch November 19, 2024 08:13
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2024
@vstinner @JelleZijlstra @miss-islington
pythongh-126594: Fix typeobject.c wrap_buffer() cast (pythonGH-126754)
d97fc20 
Reject flags smaller than INT_MIN.

(cherry picked from commit 84f07c3)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2024
@vstinner @JelleZijlstra @miss-islington
pythongh-126594: Fix typeobject.c wrap_buffer() cast (pythonGH-126754)
49c4698 
Reject flags smaller than INT_MIN.

(cherry picked from commit 84f07c3)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2024

GH-127004 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 19, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2024

GH-127005 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 19, 2024
vstinner added a commit that referenced this pull request Nov 19, 2024
@miss-islington @vstinner @JelleZijlstra
[3.12] gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754) (#1…
9345dc1 
…27005)

gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754)

Reject flags smaller than INT_MIN.

(cherry picked from commit 84f07c3)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
vstinner added a commit that referenced this pull request Nov 19, 2024
@miss-islington @vstinner @JelleZijlstra
[3.13] gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754) (#1…
fd276ad 
…27004)

gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754)

Reject flags smaller than INT_MIN.

(cherry picked from commit 84f07c3)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@vstinner @JelleZijlstra @ebonnal
pythongh-126594: Fix typeobject.c wrap_buffer() cast (python#126754)
032c25a 
Reject flags smaller than INT_MIN.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @JelleZijlstra