Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-124448: Update Windows builds to use Tcl/Tk 8.6.15 #125796

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

zware
Copy link
Member

@zware zware commented Oct 21, 2024

@zware
Copy link
Member Author

zware commented Oct 21, 2024

@zooba FYI, 8.6.15.1 only contained Tix for amd64. I created 8.6.15.2 with win32 and arm64 using git reset tcltk-8.6.13.0 arm64/tixlicense.terms arm64/lib/tix8.4.3 win32/tixlicense.terms win32/lib/tix8.4.3. Could probably use a sanity check before I merge this :)

@zooba
Copy link
Member

zooba commented Oct 21, 2024

I created 8.6.15.2 with win32 and arm64 using ...

Apart from the licenses (whoops), that's the same command I used, so yeah a sanity check would seem necessary! You could just retag 8.6.15.1 though, we don't have any commits using that version yet, so no harm in moving it.

The sanity check should probably be done by someone who knows what Tix is for. Which is not me 🙃

@zware
Copy link
Member Author

zware commented Oct 22, 2024

Apart from the licenses (whoops)

You got the amd64/tixlicense.terms, which is the only reason I thought to get them for the other two :)

that's the same command I used, so yeah a sanity check would seem necessary!

👍

You could just retag 8.6.15.1 though, we don't have any commits using that version yet, so no harm in moving it.

Tags are cheap and I'm afraid that moving one that has existed over the weekend would bring everyone who has ever cloned the repository out of the woodwork with complaints about the moved tag.

The sanity check should probably be done by someone who knows what Tix is for. Which is not me 🙃

That the tests pass is enough of a confirmation for me that Tix "works" well enough :). I was just concerned that I might have missed something with how the binaries were signed or similar, so your confirmation that a git reset was all that was needed is all I needed. Thanks!

@zware zware merged commit 7a2bd3d into python:3.12 Oct 22, 2024
29 checks passed
@zware zware deleted the backport-9d8f2d8-3.12 branch October 22, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants