Repository navigation
gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check - #125612
Merged
colesbury merged 3 commits intoDec 6, 2024
Merged
Conversation
The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.
markshannon
reviewed
Oct 24, 2024
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Looks good. Should save a few repeated deopts.
I've one suggestion
Member
|
The stats show the expected reduction in misses for |
Co-authored-by: Mark Shannon <mark@hotpy.org>
mpage
approved these changes
Dec 3, 2024
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 6, 2024
…pythonGH-125612) The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case. (cherry picked from commit a353455) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-127698 is a backport of this pull request to the 3.13 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…pythonGH-125612) The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
STORE_ATTR_INSTANCE_VALUEopcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.STORE_ATTR_INSTANCE_VALUEwithobj.__dict__#125610