gh-124855: Don't allow the JIT and perf support to be active at the same time #124856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same time Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
pablogsal
commented
Oct 1, 2024
rruuaanng
reviewed
Oct 2, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-10-01-17-31-32.gh-issue-124855.sdsv_H.rst
Show resolved
Hide resolved
|
Do we need to update the documentation here? https://docs.python.org/3.14/library/sys.html#sys.activate_stack_trampoline |
|
Good call! |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
| #ifdef _Py_JIT | ||
| _PyOptimizerObject* optimizer = _Py_GetOptimizer(); | ||
| if (optimizer != NULL) { | ||
| PyErr_SetString(PyExc_ValueError, "Cannot activate the perf trampoline if the JIT is active"); |
There was a problem hiding this comment.
You're forgetting a Py_DECREF(optimizer) I think.
There was a problem hiding this comment.
@pablogsal I'm pretty certain there's a refleak here :(
There was a problem hiding this comment.
On it, sorry I had this on auto-land and I missed your comment :(
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 30, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.