gh-124665: add _PyCodec_UnregisterError and _codecs._unregister_error
#124677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
requested review from
a team,
encukou and
ericsnowcurrently
as code owners
vstinner
reviewed
Sep 27, 2024
|
@vstinner I followed your advice and only introduced the new array. We'll just need to keep in mind that if we add a new policy, then we should also add it to the array and test it. |
picnixz
changed the title
PyCodec_UnregisterError and codecs.unregister_error_PyCodec_UnregisterError and _codecs._unregister_error
vstinner
reviewed
Sep 28, 2024
vstinner
reviewed
Sep 28, 2024
Include/internal/pycore_codecs.h
Outdated
| @@ -21,6 +21,17 @@ extern void _PyCodec_Fini(PyInterpreterState *interp); | |||
|
|
|||
| extern PyObject* _PyCodec_Lookup(const char *encoding); | |||
|
|
|||
| /* | |||
| * Un-register the error handling callback function error under the given | |||
| * name. Only non-built-in error handlers can be un-registered. | |||
There was a problem hiding this comment.
Below you use "custom". Maybe it's better name than "non-built-in". I don't know.
There was a problem hiding this comment.
I reworded the docs. WDYT?
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_PyCodec_UnregisterErrorto un-register custom error handlers #124665📚 Documentation preview 📚: https://cpython-previews--124677.org.readthedocs.build/