Skip to content

bpo-36353: fix -R option of build_ext for OSX #12418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

bpo-36353: fix -R option of build_ext for OSX #12418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3f62a5
Fix -R option of build_ext for OSX
tovrstra Mar 18, 2019
2f11292
Fix same mistake in distutils unit test
tovrstra Mar 19, 2019
5321d8a
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/distutils/tests/test_unixccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def test_runtime_libdir_option(self):

# darwin
sys.platform = 'darwin'
self.assertEqual(self.cc.rpath_foo(), '-L/foo')
self.assertEqual(self.cc.rpath_foo(), '-Wl,-rpath,/foo')

# hp-ux
sys.platform = 'hp-ux'
Expand Down
3 changes: 1 addition & 2 deletions Lib/distutils/unixccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,7 @@ def runtime_library_dir_option(self, dir):
# we use this hack.
compiler = os.path.basename(sysconfig.get_config_var("CC"))
if sys.platform[:6] == "darwin":
# MacOSX's linker doesn't understand the -R flag at all
return "-L" + dir
return "-Wl,-rpath," + dir
elif sys.platform[:7] == "freebsd":
return "-Wl,-rpath=" + dir
elif sys.platform[:5] == "hp-ux":
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2019-03-19-15-37-57.bpo-36353.GRvcMe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ``--rpath (-R)`` option of ``build_ext`` for clang on OSX. It now gets translated correctly to ``-Wl,-rpath,[argument of -R]`` instead of ``-L [argument of -R]``.