-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-124022: Fix bug where class docstring is removed in interactive mode #124023
Conversation
… interactive mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some small suggestions
Misc/NEWS.d/next/Core_and_Builtins/2024-09-12-21-53-26.gh-issue-124022.fQzUiW.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
A number of tests are failing. The issue is that now string literals in the REPL are interpreted as docstrings:
I now also understand why I made the change. I changed the code so that Interactive_kind uses A more robust solution would be to add a parameter to |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
…interactive mode (python#124023)" This reverts commit a9594a3.
Fixes #124022.
Class docstring is removed in interactive mode, but since the
first_instr
is not bumped to 1, this ends up being aNOP
with the line number of the docstring.