-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-119726: generate and patch AArch64 trampolines #123872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119726: generate and patch AArch64 trampolines #123872
Conversation
a7a04fc
to
8cbca05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I'd like to see this mechanism used across all platforms for symbols in the "global offset table" too (but that can be a separate project).
It's a clear improvement for the affected platforms:
aarch64-unknown-linux-gnu
: 0.8% faster, 0.6% less memory.aarch64-apple-darwin
: 1.5% faster, 0.8% less memory.
Here's an initial review of the Python code. I'll dig into the C code tomorrow.
Well better than nothing :) |
7bdf9f0
to
ffd74bd
Compare
f523e6a
to
43c6f98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! This is looking really good.
A few thoughts I had reading the C code:
94a2c1e
to
bf3b14f
Compare
AArch64 trampolines are now generated at runtime at the end of every trace.
ca75436
to
6723f87
Compare
Thanks! |
AArch64 trampolines are now generated at runtime at the end of every trace.