-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112328: Make EnumDict usable on its own and document it #123669
Conversation
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@ethanfurman, could you clarify how |
@ethanfurman, could you clarify how |
Thanks @encukou for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @encukou and @ethanfurman, I could not cleanly backport this to
|
|
GH-128142 is a backport of this pull request to the 3.13 branch. |
…honGH-123669) Co-authored-by: Rafi <rafi.promit@gmail.com> Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
…honGH-123669) Co-authored-by: Rafi <rafi.promit@gmail.com> Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This is a continuation of @u2rafi's PR #121720, with @AA-Turner's review comments addressed.
@ethanfurman, I noticed
EnumDict
relies on a private attribute, so I made that attribute optional, and added tests.Is this what you intended when making
EnumDict
public? Or was it more for typing andisinstance
rather than using it in custom__prepare__
?📚 Documentation preview 📚: https://cpython-previews--123669.org.readthedocs.build/