Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in unittest.mock documentation: manger -> manager #12352

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Fix typo in unittest.mock documentation: manger -> manager #12352

merged 1 commit into from
Mar 17, 2019

Conversation

massich
Copy link
Contributor

@massich massich commented Mar 15, 2019

manger-> manager

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 15, 2019
@massich
Copy link
Contributor Author

massich commented Mar 15, 2019

I've followed the instructions but I cannot find myself here https://check-python-cla.herokuapp.com/ I've signed the agreement with mailsik@gmail.com

@Mariatta Mariatta self-assigned this Mar 15, 2019
@Mariatta
Copy link
Member

Thanks. It can take 1-2 business day for us to receive your signed CLA. I will take care of this PR and backport.

@Mariatta Mariatta changed the title DOC: typo Fix typo in unittest.mock documentation: manger -> manager Mar 17, 2019
@Mariatta Mariatta merged commit dc69f69 into python:master Mar 17, 2019
@miss-islington
Copy link
Contributor

Thanks @massich for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @massich and @Mariatta, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dc69f69f14fb89511d018a3927fc6378a58d2def 3.7

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 17, 2019
@massich @Mariatta
Fix typo in unittest.mock documentation: manger -> manager (pythonGH-…
0aa05fe 
…12352)

(cherry picked from commit dc69f69)
Mariatta added a commit to Mariatta/cpython that referenced this pull request Mar 17, 2019
@Mariatta @massich
[3.7] Fix typo in unittest.mock documentation: manger -> manager (pyt…
19e6e76 
…honGH-12352).

(cherry picked from commit dc69f69)

Co-authored-by: Joan Massich <mailsik@gmail.com>
@bedevere-bot
Copy link

GH-12388 is a backport of this pull request to the 3.7 branch.

Mariatta added a commit that referenced this pull request Mar 17, 2019
@Mariatta @massich
Fix typo in unittest.mock documentation: manger -> manager (GH-12352)
76ff715 
(cherry picked from commit dc69f69)

Co-authored-by: Joan Massich <mailsik@gmail.com>
@massich
Copy link
Contributor Author

massich commented Mar 18, 2019

Thx a lot @Mariatta

@massich massich deleted the patch-1 branch March 18, 2019 15:32
@mariatta-bot
Copy link

Mariatta was mentioned, but she's out of open source from March 18th to May 9th, 2019 . Be aware she might not get to this until after PyCon US.
(I'm a bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

@Mariatta Mariatta

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@massich @the-knights-who-say-ni @Mariatta @miss-islington @bedevere-bot @mariatta-bot