Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121404: compiler_visit_* --> codegen_visit_* #123382

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 27, 2024

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a refleak (I think)

…implify error checking. Used VISIT macro instead of codegen_visit_expr
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iritkatriel iritkatriel enabled auto-merge (squash) August 27, 2024 11:32
@iritkatriel iritkatriel merged commit da43026 into python:main Aug 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants