gh-121404: remove redundant c_nestlevel. more compiler abstractions. more macro usage consistency #123225
Conversation
…ions. more macro usage consistency
iritkatriel
added
skip news
interpreter-core
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
| #define FUTURE_FEATURES(C) compiler_future_features(C) | ||
| #define SYMTABLE(C) compiler_symtable(C) | ||
| #define SYMTABLE_ENTRY(C) compiler_symtable_entry(C) | ||
| #define OPTIMIZATION_LEVEL(C) compiler_optimization_level(C) |
There was a problem hiding this comment.
I realize we have some similar macros already, but is it really worth adding a macro that just replaces a slightly longer function call?
There was a problem hiding this comment.
Eventually the functions will be in a different file, and potentially we will want to support alternative definitions of these macros. It's easier to redefine a macro than a function, and the code generation code is heavily macro-based anyway, so I think it makes sense to stick to this style.
| RETURN_IF_ERROR(ret); | ||
| return SUCCESS; |
There was a problem hiding this comment.
| RETURN_IF_ERROR(ret); | |
| return SUCCESS; | |
| return ret; |
There was a problem hiding this comment.
I deliberately didn't do this so that the pattern of checking for error with the macro is used everywhere. If you decide to add more code to this function, you can add it between line 1500 and 1501 without changing any of the existing code.
| RETURN_IF_ERROR(ret); | ||
| return SUCCESS; |
There was a problem hiding this comment.
| RETURN_IF_ERROR(ret); | |
| return SUCCESS; | |
| return ret; |
3 participants
Uh oh!
There was an error while loading. Please reload this page.