Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123123: Fix display of syntax errors covering multiple lines #123131

Merged
merged 1 commit into from
Aug 19, 2024
Merged

gh-123123: Fix display of syntax errors covering multiple lines #123131

merged 1 commit into from
Aug 19, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 18, 2024 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Aug 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 18, 2024
Closed
@pablogsal pablogsal requested a review from lysnikolaou August 18, 2024 19:40
skirpichev
skirpichev reviewed Aug 19, 2024
View reviewed changes
@skirpichev
Copy link
Member

It seems, test_syntax_error_various_offsets() should be adjusted.

@pablogsal
pythongh-123123: Fix display of syntax errors covering multiple lines
35ee545 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal enabled auto-merge (squash) August 19, 2024 14:44
@pablogsal pablogsal merged commit 48856ea into python:main Aug 19, 2024
34 checks passed
@pablogsal pablogsal deleted the gh-123123 branch August 19, 2024 15:09
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2024
@pablogsal @miss-islington
pythongh-123123: Fix display of syntax errors covering multiple lines (…
490bdbf 
…pythonGH-123131)

(cherry picked from commit 48856ea)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 19, 2024

GH-123147 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 19, 2024
pablogsal added a commit that referenced this pull request Aug 19, 2024
@miss-islington @pablogsal
[3.13] gh-123123: Fix display of syntax errors covering multiple lines (
0a02026 
GH-123131) (#123147)

gh-123123: Fix display of syntax errors covering multiple lines (GH-123131)
(cherry picked from commit 48856ea)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@pablogsal @jeremyhylton
pythongh-123123: Fix display of syntax errors covering multiple lines (…
5b434e7 
…python#123131)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@pablogsal @blhsing
pythongh-123123: Fix display of syntax errors covering multiple lines (…
88c2271 
…python#123131)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev left review comments

@tuuputamadre tuuputamadre tuuputamadre approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ambiguous invalid syntax error for a missing comma
3 participants
@pablogsal @skirpichev @tuuputamadre