Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123084: Turn shutil.ExecError into a deprecated alias of RuntimeError #123125

Merged
merged 13 commits into from
Aug 21, 2024

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Aug 18, 2024

cc @barneygale
I don't think this needs documentation updates or a "What's New" entry -- it wasn't documented in the first place.

@ZeroIntensity ZeroIntensity requested a review from Eclips4 August 18, 2024 12:51
@Eclips4 Eclips4 requested a review from barneygale August 18, 2024 14:34
@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ZeroIntensity and others added 4 commits August 20, 2024 18:22
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@ZeroIntensity
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from barneygale August 20, 2024 22:30
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ZeroIntensity and others added 3 commits August 20, 2024 18:45
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@ZeroIntensity
Copy link
Member Author

Thanks for the nits! I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from barneygale August 20, 2024 22:46
@ZeroIntensity
Copy link
Member Author

There we go! @barneygale, lint is fixed.

@barneygale
Copy link
Contributor

Thanks for this :)

@barneygale barneygale enabled auto-merge (squash) August 21, 2024 00:20
@barneygale barneygale merged commit 9dbd123 into python:main Aug 21, 2024
34 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x has failed when building commit 9dbd123.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (9dbd123) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/4

Failed tests:

  • test_android

Failed subtests:

  • test_rate_limit - test.test_android.TestAndroidOutput.test_rate_limit

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 155.1962939117436 != 100 within 10.0 delta (55.196293911743595 difference)

@ZeroIntensity
Copy link
Member Author

I doubt that's related.

@ZeroIntensity ZeroIntensity deleted the deprecate-execerror branch August 21, 2024 01:04
@mhsmith
Copy link
Member

mhsmith commented Aug 21, 2024

Looks like that test isn't as reliable as I thought. To avoid further spam, I'll shut down the Android buildbot until we get that sorted.

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants