Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27497: Add return value to csv.DictWriter.writeheader #12306

Merged
merged 4 commits into from
May 10, 2019
Merged

bpo-27497: Add return value to csv.DictWriter.writeheader #12306

merged 4 commits into from
May 10, 2019

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Mar 13, 2019 •
edited by bedevere-bot
Loading

vstinner
vstinner reviewed Mar 13, 2019
View reviewed changes
vstinner
vstinner reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please modify your commit message to credit the author using Co-Authored-By markup?

Co-Authored-By: Ashish Nitin Patil <ashishnitinpatil@gmail.com>

@remilapeyre
Copy link
Contributor Author

Thanks, I wanted to do this but was missing his email address. I will add the documentation for writerow tomorrow.

vstinner
vstinner reviewed Mar 14, 2019
View reviewed changes
vadmium
vadmium reviewed Mar 15, 2019
View reviewed changes
@remilapeyre
Copy link
Contributor Author

Hi @vstinner @vadmium! I made the requested changes, can you review again?

I also opened #12344 regarding the naming of the attribute writeline of WriterObj.

vstinner
vstinner approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer that another core dev also reviews it.

@smontanaro
Copy link
Contributor

LGTM. I downloaded the patch, applied it and verified the tests pass. @vstinner I no longer have (nor want) commit privileges. Can you take this the last mile if you have a moment?

@vstinner vstinner merged commit fce5ff1 into python:master May 10, 2019
@vstinner
Copy link
Member

LGTM. I downloaded the patch, applied it and verified the tests pass. @vstinner I no longer have (nor want) commit privileges. Can you take this the last mile if you have a moment?

Done, thanks for the review @smontanaro ;-)

@remilapeyre remilapeyre mentioned this pull request May 14, 2019
Merged
@slateny slateny mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium vadmium left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@remilapeyre @smontanaro @vstinner @vadmium @the-knights-who-say-ni @bedevere-bot