Fix old-style print statement in gettext comments
#122939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
LGTM.
Actually, there are a couple of other entries of old print statements:
- Lib/textwrap.py: Line 495-496
- Lib/idlelib/colorizer.py: Line 293
- Lib/logging/config.py: Line 427
- Lib/test/test_decimal.py: Line 302, Line 319
- Lib/test/test_set.py: Line 1581
- Lib/test/test_stringprep.py: Line 89
- Lib/test/support/script_helper.py: Line 260, Line 296
I'm not sure if this should be done during this PR.
AA-Turner
approved these changes
Aug 12, 2024
|
I'd consolidate in one PR rather than opening multiple smaller ones (e.g. #122940). A |
|
I opened several, because this one won't be backported, while #122940 will be, since it is a documentation fix. And this one is a refactoring. Thanks for the reviews! 👍 |
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.