gh-112301: Add Warning Count to Warning Check Tooling #122711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Aug 7, 2024
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
sethmlarson
reviewed
Aug 13, 2024
sethmlarson
approved these changes
Aug 13, 2024
hugovk
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Reminder: you can commit these changes via the GitHub UI: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…22711) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feature of specifying how many warnings should be ignored in a particular file for the check compiler warning tooling. This makes adding a particular file to the warning ignore files a bit more tolerable because it means that changes that introduce more warnings to a file will be caught. If a warning is fixed by a change but a new warning is introduced this will not be caught, however. That would require maintaining a list of specific warnings to ignore, which would be a bit overkill.
This change also removes duplicate warnings from being processed by the tooling, so that the accurate number of warnings per file can be specified when ignoring warnings in the
.warningignore_*file.