Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121996: Fix --disable-safety and --enable-slower-safety options #122414

Merged
merged 2 commits into from
Jul 29, 2024
Merged

gh-121996: Fix --disable-safety and --enable-slower-safety options #122414

merged 2 commits into from
Jul 29, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jul 29, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 29, 2024
Closed
@corona10 corona10 added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Jul 29, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 0c43586 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 29, 2024
@corona10
Copy link
Member Author

corona10 commented Jul 29, 2024 •
edited
Loading

@nohlson cc @sethmlarson

  • There was a mistake in the script.. Default safety options were not applied for a while; the PR will fix the bug.
  • I switched to use CFLAGS_NODIST instead of BASECFLAGS, not to propgrate the compiler option to outside.

@corona10 corona10 added the type-bug An unexpected behavior, bug, or error label Jul 29, 2024
@corona10 corona10 self-assigned this Jul 29, 2024
@corona10 corona10 enabled auto-merge (squash) July 29, 2024 18:52
@corona10 corona10 merged commit 046670c into python:main Jul 29, 2024
59 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

@corona10 corona10

Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @bedevere-bot