gh-122400: Handle ValueError in filecmp
#122401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 3a9b2aa) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 3a9b2aa) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-122441 is a backport of this pull request to the 3.13 branch. |
|
GH-122442 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 30, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 30, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be backported to 3.12 and 3.13 but I need confirmation before applying the labels.
ValueErrorinfilecmp.dircmpandfilecmp.cmpfiles#122400