[2.7] bpo-36234: test_os: check TypeError for invalid uid type #12235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
reviewed
Mar 8, 2019
| self.assertRaises(OverflowError, os.setegid, 1<<32) | ||
|
|
||
| @unittest.skipUnless(hasattr(os, 'setreuid'), 'test needs os.setreuid()') | ||
| def test_setreuid(self): | ||
| if os.getuid() != 0: | ||
| self.assertRaises(os.error, os.setreuid, 0, 0) | ||
| self.assertRaises(TypeError, os.setreuid, 'not an int', 0) |
There was a problem hiding this comment.
Which context? Context of what?
There was a problem hiding this comment.
Sorry, something like this:
with self.assertRaises(TypeError):
os.setreuid(...)
There was a problem hiding this comment.
It's basically the same. Both variants are used in Python test suite. Here I just applied David's patch to make it upstream.
|
See also PR #12234 for the mastesr branch. |
serhiy-storchaka
approved these changes
Mar 10, 2019
Patch written by David Malcolm. Co-Authored-By: David Malcolm <dmalcolm@redhat.com>
|
I modified the NEWS entry to add "Patch written by David Malcolm." I forgot to credit David there! |
jua74470
pushed a commit
to jua74470/python2.7
that referenced
this pull request
Nov 14, 2024
Upstreamed patches: - 157: python/cpython#12235 - 168: python/cpython#12349 Rebased patches: - 189: updated bundles setuptools/pip versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch written by David Malcolm.
Co-Authored-By: David Malcolm dmalcolm@redhat.com
https://bugs.python.org/issue36234