gh-122044: Don't error during gitignore filtering with no files #122045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running this patch locally after removing the |
|
Hope you don't mind reviewing this one Hugo, fairly small one that fixes SBOMs when projects get removed (as is being done now for libb2). |
|
Thanks! And backport to 3.12? |
sethmlarson
added
needs backport to 3.12
|
Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2024
…pythonGH-122045) (cherry picked from commit 4e04d1a) Co-authored-by: Seth Michael Larson <seth@python.org>
|
GH-122354 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2024
…pythonGH-122045) (cherry picked from commit 4e04d1a) Co-authored-by: Seth Michael Larson <seth@python.org>
|
GH-122355 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jul 27, 2024
hugovk
pushed a commit
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package doesn't have any files the script errors during gitignore filtering instead of the helpful error message.