Skip to content

gh-65453: Docs - clarify AttributeError behaviour on PropertyMock #121666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2024
Merged

gh-65453: Docs - clarify AttributeError behaviour on PropertyMock #121666

merged 2 commits into from
Jul 18, 2024

Conversation

ziima
Copy link
Contributor

@ziima ziima commented Jul 13, 2024 •
edited by github-actions bot
Loading

@ghost
Copy link

ghost commented Jul 13, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 13, 2024
encukou
encukou reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
There are a few things to improve, mostly related to Sphinx and restructured text.

(I didn't test the suggestion.)

@ziima @encukou
fixup! Reformat the text output of unittest
013b879 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@encukou encukou merged commit 94e6644 into python:main Jul 18, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @ziima for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
@ziima @miss-islington
pythongh-65453: Docs - clarify AttributeError behaviour on PropertyMo…
7b378b6 
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
@ziima @miss-islington
pythongh-65453: Docs - clarify AttributeError behaviour on PropertyMo…
60d844d 
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121968 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121969 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 18, 2024
encukou pushed a commit that referenced this pull request Jul 19, 2024
@miss-islington @ziima
[3.13] gh-65453: Docs - clarify AttributeError behaviour on PropertyM…
7f63241 
…ock (GH-121666) (GH-121968)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Jul 19, 2024
@miss-islington @ziima
[3.12] gh-65453: Docs - clarify AttributeError behaviour on PropertyM…
b1c31a1 
…ock (GH-121666) (GH-121969)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziima @encukou