Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36182: Update pathlib.Path.write_text() docs with the case of an existing file #12161

Merged
merged 1 commit into from
Sep 11, 2019
Merged

bpo-36182: Update pathlib.Path.write_text() docs with the case of an existing file #12161

merged 1 commit into from
Sep 11, 2019

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Mar 4, 2019 •
edited by bedevere-bot
Loading

@lysnikolaou
bpo-36182: Update pathlib.Path.write_text() docs
eb45ccb 
with the case of an existing file
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 4, 2019
tirkarthi
tirkarthi approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this :)

@csabella csabella requested a review from pitrou June 5, 2019 01:11
@JulienPalard JulienPalard merged commit af636f4 into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@lysnikolaou @miss-islington
bpo-36182: Update pathlib.Path.write_text() docs (pythonGH-12161)
79257be 
with the case of an existing file
(cherry picked from commit af636f4)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link

GH-15977 is a backport of this pull request to the 3.8 branch.

JulienPalard pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @lysnikolaou @JulienPalard
bpo-36182: Update pathlib.Path.write_text() docs (GH-12161) (GH-15977)
8936533 
with the case of an existing file
(cherry picked from commit af636f4)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@lysnikolaou @DinoV
bpo-36182: Update pathlib.Path.write_text() docs (pythonGH-12161)
fec4732 
with the case of an existing file
@lysnikolaou lysnikolaou deleted the bpo36182 branch May 8, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lysnikolaou @miss-islington @bedevere-bot @tirkarthi @JulienPalard @the-knights-who-say-ni