Skip to content

gh-121376: Switch from stat.st_mtime to stat.mtime_ns to achieve more accuracy #121502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jul 8, 2024

@Eclips4
Copy link
Member Author

Eclips4 commented Jul 8, 2024

This is a PoC.
If this is a right solution, the same change should be applied to compileall/py_compile (but it would be more difficult), so failures in py_compile and compileall(and couple of other tests..)are expected.

@Zheaoli @nekopsykose can you confirm this is resolves problem on your systems?
(Note: this PR only modifies Python code, but some parts of the importlib module are frozen during the compilation process of the interpreter, so you will need to rebuild the interpreter in order to apply these changes.)

@nekopsykose
Copy link

it fixes it, yeah

@Eclips4
Copy link
Member Author

Eclips4 commented Jul 10, 2024

Closing per #121376 (comment)

@Eclips4 Eclips4 closed this Jul 10, 2024
@Eclips4 Eclips4 deleted the issue-121376 branch July 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants