Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29802: Fix reference counting in module-level struct functions #1213

Merged
merged 2 commits into from
Apr 20, 2017
Merged

bpo-29802: Fix reference counting in module-level struct functions #1213

merged 2 commits into from
Apr 20, 2017

Conversation

serhiy-storchaka
Copy link
Member

when pass argumens of wrong type.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Apr 20, 2017
@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mdickinson, @Yhg1s and @benjaminp to be potential reviewers.

zhangyangyu
zhangyangyu approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@zhangyangyu zhangyangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Except there is one typo in NEWS: argumens -> arguments.

@serhiy-storchaka serhiy-storchaka merged commit 40db90c into python:master Apr 20, 2017
@serhiy-storchaka serhiy-storchaka deleted the struct-cache_struct_converter-cleanup branch April 20, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @mention-bot @zhangyangyu @the-knights-who-say-ni