gh-121285: Remove backtracking when parsing tarfile headers#121286
Merged
gpshead merged 11 commits intopython:mainfrom Aug 31, 2024
Merged
gh-121285: Remove backtracking when parsing tarfile headers#121286gpshead merged 11 commits intopython:mainfrom
gpshead merged 11 commits intopython:mainfrom
Conversation
Eclips4
reviewed
Jul 2, 2024
Misc/NEWS.d/next/Security/2024-07-02-13-39-20.gh-issue-121285.hrl-yI.rst
Outdated
Show resolved
Hide resolved
…hrl-yI.rst Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
sethmlarson
added
type-security
Member
|
@sethmlarson Did you mean to add the "Needs backport to 3.x" labels rather than the "3.x" ones? |
sethmlarson
added
needs backport to 3.8
needs backport to 3.10
Contributor
Author
|
@hugovk Yes! Selected the wrong range of tags, my bad. |
ethanfurman
requested changes
Jul 2, 2024
Member
ethanfurman
left a comment
ethanfurman
left a comment
There was a problem hiding this comment.
Please remove the type hints.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Sep 3, 2024
…ers (pythonGH-121286) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-123639 is a backport of this pull request to the 3.11 branch. |
|
GH-123639 is a backport of this pull request to the 3.11 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Sep 3, 2024
…ers (pythonGH-121286) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-123640 is a backport of this pull request to the 3.10 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Sep 3, 2024
…rs (pythonGH-121286) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-123641 is a backport of this pull request to the 3.9 branch. |
sethmlarson
added a commit
to sethmlarson/cpython
that referenced
this pull request
Sep 3, 2024
…rs (pythonGH-121286) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-123642 is a backport of this pull request to the 3.8 branch. |
Contributor
Author
|
Backports have been created. |
pablogsal
pushed a commit
that referenced
this pull request
Sep 3, 2024
…H-121286) (#123639) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
pablogsal
pushed a commit
that referenced
this pull request
Sep 3, 2024
…H-121286) (#123640) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
…-121286) (#123642) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
…-121286) (#123641) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness
pushed a commit
to frenzymadness/cpython
that referenced
this pull request
Sep 5, 2024
…e headers (pythonGH-121286) (python#123642) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness
added a commit
to frenzymadness/cpython
that referenced
this pull request
Sep 5, 2024
…e headers (pythonGH-121286) (python#123642) * Remove backtracking when parsing tarfile headers * Rewrite PAX header parsing to be stricter * Optimize parsing of GNU extended sparse headers v0.0 (cherry picked from commit 34ddb64) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Lumír Balhar <lbalhar@redhat.com>
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 6, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 9, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 10, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 10, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 10, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
May 14, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 15, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
May 15, 2025
…nGH-121286) Patched from: https://github.com/python/cpython/commit/7d1f50cd92ff7e10a1c15a8f591dde8a6843a64d.patch Had one reject, hand updated it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all instances of backtracking from parsing tarfile headers, specifically
hdrcharset, PAX, and GNU sparse headers.