Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121199: Use _Py__has_attribute() in timemodule.c #121203

Merged
merged 1 commit into from
Jul 1, 2024
Merged

gh-121199: Use _Py__has_attribute() in timemodule.c #121203

merged 1 commit into from
Jul 1, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 1, 2024 •
edited by bedevere-app bot
Loading

Use the _Py__has_attribute() macro in timemodule.c and bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5 on s390x).

@vstinner
pythongh-121199: Use _Py__has_attribute() in timemodule.c
4249c09 
Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2024
Closed
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

!buildbot s390x RHEL7 PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 4249c09 🤖

The command will test the builders whose names match following regular expression: s390x RHEL7 PR

The builders matched are:

  • s390x RHEL7 PR

@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

My change fix the build: s390x RHEL7 PR https://buildbot.python.org/all/#/builders/177/builds/1436 built successfully.

@vstinner vstinner enabled auto-merge (squash) July 1, 2024 08:37
@vstinner vstinner merged commit a0b8b34 into python:main Jul 1, 2024
37 checks passed
@vstinner vstinner deleted the has_attribute branch July 1, 2024 08:49
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vstinner @Akasurde
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
ae955a1 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
3e97b3f 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
eef1d9b 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot