[3.12] gh-120522: Add a --with-app-store-compliance configure option to patch out problematic code (GH-120984)
#121174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option to patch out problematic code (pythonGH-120984) * Add --app-store-compliance configuration option. * Added blurb. * Correct tab-vs-spaces formatting issue. * Correct source file name in docs. Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> * Correct source code reference in Mac docs Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> * Only apply the patch forward, and ensure the working directory is correct. * Make patching reslient to multiple builds. * Documentation fixes found during review Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com> * Documentation and configure.ac syntax improvements Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Regenerate configure script. * Silence the patch echo output. --------- (cherry picked from commit 48cd104) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
requested review from
a team,
erlend-aasland and
corona10
as code owners
This was referenced Jun 30, 2024
|
@Yhg1s Summary of context for this: The underlying issue (the macOS App Store rejecting the Python 3.12 standard library) exists in 3.12; but this isn't a traditional bug fix - it's a built-in way to patch the issue if you're planning to submit to the macOS App Store. This requires adding a new configuration option (which could be considered a new feature). The underlying fix can be applied manually. I've tagged you for review since it's your call as release manager call whether this is appropriate for backport. I'm completely happy if the answer is to close this backport as a WONTFIX. |
|
I'm going to close this PR; the approach has been modified slightly; the new version to be backported is in #121830. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --app-store-compliance configuration option.
Added blurb.
Correct tab-vs-spaces formatting issue.
Correct source file name in docs.
Correct source code reference in Mac docs
Only apply the patch forward, and ensure the working directory is correct.
Make patching reslient to multiple builds.
Documentation fixes found during review
Documentation and configure.ac syntax improvements
Regenerate configure script.
Silence the patch echo output.
(cherry picked from commit 48cd104)
📚 Documentation preview 📚: https://cpython-previews--121174.org.readthedocs.build/