Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121018: ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments #121019

Merged
merged 3 commits into from
Jun 26, 2024
Merged

gh-121018: ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments #121019

merged 3 commits into from
Jun 26, 2024

Conversation

blhsing
Copy link
Contributor

@blhsing blhsing commented Jun 26, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 26, 2024
Closed
@blhsing blhsing changed the title gh-121018: ensure ArgumentParser.parse_args raises instead of exiting when given unrecognized arguments gh-121018: ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments Jun 26, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 0654336 into python:main Jun 26, 2024
38 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 26, 2024
@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
@blhsing @miss-islington
pythongh-121018: Ensure ArgumentParser.parse_args with exit_on_error=…
40945ff 
…False raises instead of exiting when given unrecognized arguments (pythonGH-121019)

(cherry picked from commit 0654336)

Co-authored-by: blhsing <blhsing@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
@blhsing @miss-islington
pythongh-121018: Ensure ArgumentParser.parse_args with exit_on_error=…
c8e2d55 
…False raises instead of exiting when given unrecognized arguments (pythonGH-121019)

(cherry picked from commit 0654336)

Co-authored-by: blhsing <blhsing@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2024

GH-121031 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 26, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2024

GH-121032 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2024
@blhsing blhsing deleted the fix-argparse-exit-on-error-with-unrecognized-args branch June 26, 2024 07:44
serhiy-storchaka pushed a commit that referenced this pull request Jun 26, 2024
@miss-islington @blhsing
[3.13] gh-121018: Ensure ArgumentParser.parse_args with exit_on_error…
6bc7e2c 
…=False raises instead of exiting when given unrecognized arguments (GH-121019) (GH-121032)

(cherry picked from commit 0654336)

Co-authored-by: blhsing <blhsing@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 26, 2024
@miss-islington @blhsing
[3.12] gh-121018: Ensure ArgumentParser.parse_args with exit_on_error…
4868d1b 
…=False raises instead of exiting when given unrecognized arguments (GH-121019) (GH-121031)

(cherry picked from commit 0654336)

Co-authored-by: blhsing <blhsing@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@blhsing @mrahtz
pythongh-121018: Ensure ArgumentParser.parse_args with exit_on_error=…
1915e7b 
…False raises instead of exiting when given unrecognized arguments (pythonGH-121019)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@blhsing @noahbkim
pythongh-121018: Ensure ArgumentParser.parse_args with exit_on_error=…
6a460dc 
…False raises instead of exiting when given unrecognized arguments (pythonGH-121019)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@blhsing @estyxx
pythongh-121018: Ensure ArgumentParser.parse_args with exit_on_error=…
226c7eb 
…False raises instead of exiting when given unrecognized arguments (pythonGH-121019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blhsing @serhiy-storchaka