gh-98442: fix locations of with statement's cleanup instructions #120763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
needs backport to 3.12
|
|
||
| # Expect three load None instructions for the no-exception __exit__ call, | ||
| # and one RETURN_VALUE. | ||
| # They should all have the locations of the context manager ('xyz'). |
There was a problem hiding this comment.
Why doesn't the RETURN_VALUE have the location of the return statement?
There was a problem hiding this comment.
The calculation of the value has that location. The return itself occurs after the exit, so it gets the location of the exit (the last instruction executed before the return).
JelleZijlstra
approved these changes
Jun 20, 2024
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 20, 2024
pythonGH-120763) (cherry picked from commit 55596ae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> pythongh-98442: fix location of with statement's cleanup instructions
|
GH-120786 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 20, 2024
pythonGH-120763) (cherry picked from commit 55596ae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> pythongh-98442: fix location of with statement's cleanup instructions
|
GH-120787 is a backport of this pull request to the 3.12 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
python#120763) pythongh-98442: fix location of with statement's cleanup instructions
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
python#120763) pythongh-98442: fix location of with statement's cleanup instructions
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
python#120763) pythongh-98442: fix location of with statement's cleanup instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98442.