gh-120367: fix bug where compiler detects redundant jump after pseudo op replacement #120714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
carljm
approved these changes
Jun 18, 2024
iritkatriel
commented
Jun 18, 2024
Misc/NEWS.d/next/Core and Builtins/2024-06-18-21-34-30.gh-issue-120367.zDwffP.rst
Outdated
Show resolved
Hide resolved
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2024
…pseudo op replacement (pythonGH-120714) (cherry picked from commit b7f4789) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-120716 is a backport of this pull request to the 3.13 branch. |
iritkatriel
pushed a commit
that referenced
this pull request
Jun 18, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…pseudo op replacement (python#120714)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…pseudo op replacement (python#120714)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…pseudo op replacement (python#120714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120367.
This can't happen with an AST that comes from real code, because the try can't be on the same line as the following instruction. It can happen with a synthetic AST though.