gh-120083: Add IDLE Hovertip foreground color needed for recent macOS #120605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue w/ Hovertip foreground color causing tooltip text not to render on Mac OS Add params for foreground and background to Hovertip.__init__()
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
JRiggles
changed the title
terryjreedy
reviewed
Aug 1, 2024
terryjreedy
reviewed
Aug 1, 2024
terryjreedy
changed the title
terryjreedy
reviewed
Aug 1, 2024
Misc/NEWS.d/next/IDLE/2024-06-16-21-42-45.gh-issue-120083.nczuyv.rst
Outdated
Show resolved
Hide resolved
|
3.13 backport review: Rationale is described in commit message and shown in linked image from mac Sonoma. |
terryjreedy
added
3.12
|
Thanks @JRiggles for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 2, 2024
… macOS (pythonGH-120605) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (pythonGH-120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- (cherry picked from commit 5a7f7c4) Co-authored-by: John Riggles <jriggles@icloud.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-122592 is a backport of this pull request to the 3.12 branch. |
|
Thanks @JRiggles for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2024
… macOS (pythonGH-120605) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (pythonGH-120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- (cherry picked from commit 5a7f7c4) Co-authored-by: John Riggles <jriggles@icloud.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-122739 is a backport of this pull request to the 3.13 branch. |
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
… macOS (python#120605) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (python#120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
added a commit
that referenced
this pull request
Aug 9, 2024
…t macOS (GH-120605) (#122592) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (GH-120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- (cherry picked from commit 5a7f7c4) Co-authored-by: John Riggles <jriggles@icloud.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
… macOS (python#120605) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (python#120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 2, 2024
…t macOS (GH-120605) (#122739) gh-120083: Add IDLE Hovertip foreground color needed for recent macOS (GH-120605) On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (GH-120083 (comment)). The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE. --------- (cherry picked from commit 5a7f7c4) Co-authored-by: John Riggles <jriggles@icloud.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On recent versions of macOS (sometime between Catalina and Sonoma 14.5), the default Hovertip foreground color changed from black to white, thereby matching the background. This might be a matter of matching the white foreground of the dark-mode text. The unreadable result is shown here (#120083 (comment)).
The foreground and background colors were made parameters so we can pass different colors for future additional hovertips in IDLE.