[3.13] gh-120526: Correct signature of map() builtin (GH-120528) #120539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
map() requires at least one iterable arg. (cherry picked from commit d4039d3) Co-authored-by: Adam Williamson <adam@blueradius.ca> Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
All commit authors signed the Contributor License Agreement. |
This was referenced Jun 15, 2024
|
@AdamWill looks like the commit is getting attributed to a different email address; could you sign the CLA with this email address too? |
|
Huh, that's weird. Only reason I can think it'd get that email is that it's the primary on my github account, it's not on the original commit at all. I don't mind signing with that address too, but seems like maybe a bug in whatever came with this "co-authored by" attribution? |
|
This is the first time I see this. The original PR was merged, a complain was raised about the backport (which refers to the same email address), but it did not prevent automerging. Did you just sign the CLA for your second address, @AdamWill? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map() requires at least one iterable arg.
(cherry picked from commit d4039d3)
Co-authored-by: Adam Williamson adam@blueradius.ca
Signed-off-by: Adam Williamson awilliam@redhat.com
inspect.signature(map)works in Python 3.13, but gives a signature that looks like only one arg is required #120526