Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty Dictionaries section from FAQ #12026

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Remove empty Dictionaries section from FAQ #12026

merged 1 commit into from
Feb 25, 2019

Conversation

andresdelfino
Copy link
Contributor

Doesn't have any use since 396ecb9.

Before that commit, these two questions were below that title when they shouldn't have:

  • I want to do a complicated sort: can you do a Schwartzian Transform in Python?
  • How can I sort one list by values from another list?

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 25, 2019
eamanu
eamanu approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The two questions below Dictionaries title refer to type/list

Hi, I recommend you open a bpo. Some core devs doesn't have github account.

@csabella csabella self-assigned this Feb 25, 2019
vstinner
vstinner approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@csabella csabella merged commit 55e335d into python:master Feb 25, 2019
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2019
@andresdelfino @miss-islington
Remove empty Dictionaries section from programming FAQ (pythonGH-12026)
d8a6d8e 
(cherry picked from commit 55e335d)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-12030 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 25, 2019
@miss-islington @andresdelfino
Remove empty Dictionaries section from programming FAQ (GH-12026)
a1caf65 
(cherry picked from commit 55e335d)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the remove-dictionaries-faq branch March 6, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@eamanu eamanu eamanu approved these changes

@csabella csabella csabella approved these changes

Assignees

@csabella csabella

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andresdelfino @miss-islington @bedevere-bot @vstinner @eamanu @csabella @the-knights-who-say-ni