gh-120039: Reduce expected timeout in test_siginterrupt_off #120047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes.
colesbury
added
tests
colesbury
added
skip news
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit f88aceb 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
serhiy-storchaka
approved these changes
Jun 4, 2024
Lib/test/test_signal.py
Outdated
| @@ -698,7 +698,7 @@ def handler(signum, frame): | |||
| @unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()") | |||
| class SiginterruptTest(unittest.TestCase): | |||
|
|
|||
| def readpipe_interrupted(self, interrupt): | |||
| def readpipe_interrupted(self, interrupt, timeout): | |||
There was a problem hiding this comment.
In 2 of 3 cases the value is support.SHORT_TIMEOUT, so you can make it the default value to reduce the diff.
serhiy-storchaka
approved these changes
Jun 4, 2024
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
…thonGH-120047) The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes. (cherry picked from commit d419d46) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-120060 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
…thonGH-120047) The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes. (cherry picked from commit d419d46) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-120061 is a backport of this pull request to the 3.12 branch. |
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
…thon#120047) The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…thon#120047) The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…thon#120047) The process is expected to time out. In the refleak builds, `support.SHORT_TIMEOUT` is often five minutes and we run the tests six times, so test_signal was taking >30 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process is expected to time out. In the refleak builds,
support.SHORT_TIMEOUTis often five minutes and we run the tests six times, so test_signal was taking >30 minutes.test_siginterrupt_offunnecessarily takes 30 minutes in refleak test #120039