Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36064: Clarify allowed data types for urllib.request.Request. #11990

Merged
merged 1 commit into from
Mar 29, 2019
Merged

bpo-36064: Clarify allowed data types for urllib.request.Request. #11990

merged 1 commit into from
Mar 29, 2019

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Feb 22, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Feb 22, 2019
tirkarthi
tirkarthi approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

eamanu
eamanu approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

willingc
willingc approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@willingc
Copy link
Contributor

Thanks @JulienPalard for the PR and @tirkarthi and @eamanu for the reviews. 🍪

@willingc willingc merged commit 9e30fba into python:master Mar 29, 2019
@tirkarthi
Copy link
Member

I hope this can be backported to 3.7 ?

@JulienPalard JulienPalard deleted the issue36064 branch June 16, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JulienPalard @willingc @tirkarthi @eamanu @the-knights-who-say-ni @bedevere-bot