Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20582: add link for manpage for flags on getnameinfo() #11977

Merged
merged 4 commits into from
Apr 11, 2019
Merged

bpo-20582: add link for manpage for flags on getnameinfo() #11977

merged 4 commits into from
Apr 11, 2019

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Feb 21, 2019 •
edited by brettcannon
Loading

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 21, 2019
@matrixise
Copy link
Member

@JulienPalard do we need a blurb entry for this issue? or add the skip-news label.

LGTM

@JulienPalard @eamanu
Update Doc/library/socket.rst
0a79ef6 
add @JulienPalard suggestion

Co-Authored-By: eamanu <emmanuelarias30@gmail.com>
@eamanu
Copy link
Contributor Author

eamanu commented Feb 22, 2019

Ready @JulienPalard

@csabella
Copy link
Contributor

Please take a look at Serhiy's comment on the bug tracker.

@eamanu
Copy link
Contributor Author

eamanu commented Feb 24, 2019

oops!

@eamanu
Copy link
Contributor Author

eamanu commented Feb 24, 2019

Sorry everybody for the noise. I was wrong on the push.

Thanks @csabella I make the suggestion

@eamanu
Copy link
Contributor Author

eamanu commented Feb 28, 2019

ping @JulienPalard :-)

brettcannon
brettcannon requested changes Apr 2, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon @eamanu
Update Doc/library/socket.rst
9690d02 
Add @brettcannon suggestion.

Co-Authored-By: eamanu <emmanuelarias30@gmail.com>
@eamanu
Copy link
Contributor Author

eamanu commented Apr 3, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@miss-islington miss-islington merged commit 3993ccb into python:master Apr 11, 2019
@brettcannon
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard left review comments

@brettcannon brettcannon brettcannon approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eamanu @matrixise @csabella @bedevere-bot @brettcannon @JulienPalard @the-knights-who-say-ni @miss-islington