Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119627: removed asyncio deprecated classes and methods #119684

Closed
wants to merge 3 commits into from
Closed

gh-119627: removed asyncio deprecated classes and methods #119684

wants to merge 3 commits into from

Conversation

SweetyAngel
Copy link
Contributor

@SweetyAngel SweetyAngel commented May 28, 2024

gh-119627: Removed asyncio classes and methods that were deprecated after 3.12 version


📚 Documentation preview 📚: https://cpython-previews--119684.org.readthedocs.build/

Copy link

cpython-cla-bot bot commented May 28, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not complete, it just deletes undeprecated functionality. I will change it to draft mode, then you can keep developing it further.

@@ -50,7 +44,7 @@ def waitstatus_to_exitcode(status):
return os.waitstatus_to_exitcode(status)
except ValueError:
# The child exited, but we don't understand its status.
# This shouldn't happen, but if it does, let's just
# This shouldn't happen, but if it does, let's justFC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This shouldn't happen, but if it does, let's justFC
# This shouldn't happen, but if it does, let's just

@gvanrossum gvanrossum marked this pull request as draft May 31, 2024 01:30
@SweetyAngel SweetyAngel closed this by deleting the head repository Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants